Minor fixes, remove todos

This commit is contained in:
Hexah 2020-06-16 21:52:03 +02:00
parent c922fedc5f
commit cf56fd7c38
4 changed files with 4 additions and 6 deletions

View File

@ -4,7 +4,7 @@
- Implemented `withHighestBitrate` and `sortByBitrate` for `StreamInfo` iterables.
- Implemented `withHighestBitrate` for `VideoStreamInfo` iterables.
- Now `sortByVideoQuality` returns a List of `T`.
- `SearchQuery.nextPage` now returns null if there is no next page.
## 1.1.0
- Implement parsing of the search page to retrieve information from youtube searches. See `SearchQuery`.

View File

@ -37,7 +37,6 @@ android {
}
defaultConfig {
// TODO: Specify your own unique Application ID (https://developer.android.com/studio/build/application-id.html).
applicationId "net.hexah.video_download_flutter"
minSdkVersion 16
targetSdkVersion 28
@ -48,7 +47,6 @@ android {
buildTypes {
release {
// TODO: Add your own signing config for the release build.
// Signing with the debug keys for now, so `flutter run --release` works.
signingConfig signingConfigs.debug
}

View File

@ -196,7 +196,7 @@ class _InitialData {
}
if (content.containsKey('videoRenderer')) {
Map<String, dynamic> renderer = content['videoRenderer'];
//TODO: Add it's a live
//TODO: Add if it's a live
return SearchVideo(
VideoId(renderer['videoId']),
_parseRuns(renderer['title']),

View File

@ -22,11 +22,11 @@ class SearchQuery {
}
/// Get the data of the next page.
/// Returns null if there is no next page.
Future<SearchQuery> nextPage() async {
var page = await _page.nextPage(_httpClient);
if (page == null) {
// TODO: Throw custom exception
throw Exception('Page limit reached!');
return null;
}
return SearchQuery(_httpClient, searchQuery, page);
}