Minor fixes, remove todos
This commit is contained in:
parent
c922fedc5f
commit
cf56fd7c38
|
@ -4,7 +4,7 @@
|
||||||
- Implemented `withHighestBitrate` and `sortByBitrate` for `StreamInfo` iterables.
|
- Implemented `withHighestBitrate` and `sortByBitrate` for `StreamInfo` iterables.
|
||||||
- Implemented `withHighestBitrate` for `VideoStreamInfo` iterables.
|
- Implemented `withHighestBitrate` for `VideoStreamInfo` iterables.
|
||||||
- Now `sortByVideoQuality` returns a List of `T`.
|
- Now `sortByVideoQuality` returns a List of `T`.
|
||||||
|
- `SearchQuery.nextPage` now returns null if there is no next page.
|
||||||
## 1.1.0
|
## 1.1.0
|
||||||
- Implement parsing of the search page to retrieve information from youtube searches. See `SearchQuery`.
|
- Implement parsing of the search page to retrieve information from youtube searches. See `SearchQuery`.
|
||||||
|
|
||||||
|
|
|
@ -37,7 +37,6 @@ android {
|
||||||
}
|
}
|
||||||
|
|
||||||
defaultConfig {
|
defaultConfig {
|
||||||
// TODO: Specify your own unique Application ID (https://developer.android.com/studio/build/application-id.html).
|
|
||||||
applicationId "net.hexah.video_download_flutter"
|
applicationId "net.hexah.video_download_flutter"
|
||||||
minSdkVersion 16
|
minSdkVersion 16
|
||||||
targetSdkVersion 28
|
targetSdkVersion 28
|
||||||
|
@ -48,7 +47,6 @@ android {
|
||||||
|
|
||||||
buildTypes {
|
buildTypes {
|
||||||
release {
|
release {
|
||||||
// TODO: Add your own signing config for the release build.
|
|
||||||
// Signing with the debug keys for now, so `flutter run --release` works.
|
// Signing with the debug keys for now, so `flutter run --release` works.
|
||||||
signingConfig signingConfigs.debug
|
signingConfig signingConfigs.debug
|
||||||
}
|
}
|
||||||
|
|
|
@ -196,7 +196,7 @@ class _InitialData {
|
||||||
}
|
}
|
||||||
if (content.containsKey('videoRenderer')) {
|
if (content.containsKey('videoRenderer')) {
|
||||||
Map<String, dynamic> renderer = content['videoRenderer'];
|
Map<String, dynamic> renderer = content['videoRenderer'];
|
||||||
//TODO: Add it's a live
|
//TODO: Add if it's a live
|
||||||
return SearchVideo(
|
return SearchVideo(
|
||||||
VideoId(renderer['videoId']),
|
VideoId(renderer['videoId']),
|
||||||
_parseRuns(renderer['title']),
|
_parseRuns(renderer['title']),
|
||||||
|
|
|
@ -22,11 +22,11 @@ class SearchQuery {
|
||||||
}
|
}
|
||||||
|
|
||||||
/// Get the data of the next page.
|
/// Get the data of the next page.
|
||||||
|
/// Returns null if there is no next page.
|
||||||
Future<SearchQuery> nextPage() async {
|
Future<SearchQuery> nextPage() async {
|
||||||
var page = await _page.nextPage(_httpClient);
|
var page = await _page.nextPage(_httpClient);
|
||||||
if (page == null) {
|
if (page == null) {
|
||||||
// TODO: Throw custom exception
|
return null;
|
||||||
throw Exception('Page limit reached!');
|
|
||||||
}
|
}
|
||||||
return SearchQuery(_httpClient, searchQuery, page);
|
return SearchQuery(_httpClient, searchQuery, page);
|
||||||
}
|
}
|
||||||
|
|
Loading…
Reference in New Issue