install.sh over-writes config #4

New Issue

mixmix · 2020-03-20T08:48:21+01:00

mixmix commented

2020-03-20 08:48:21 +01:00

This line in install.sh would appear to totally nuke any existing config stored there. That could be quite upsetting

	mkdir -p ~/.ssb
	cat > ~/.ssb/config <<EOF
{
  "connections": {
    "incoming": {
      "net": [
        {
          "scope": "public", "external": ["$EXTERNAL"], "transform": "shs", "port": 8008
        },
        { "scope": "private", "transform": "shs", "port": 8008, "host": "127.0.0.1" }
      ]
    },
    "outgoing": {
      "net": [
        {
          "transform": "shs"
        }
      ]
    }
  }
}
EOF

This line in `install.sh` would appear to totally nuke any existing config stored there. That could be quite upsetting ``` mkdir -p ~/.ssb cat > ~/.ssb/config <<EOF { "connections": { "incoming": { "net": [ { "scope": "public", "external": ["$EXTERNAL"], "transform": "shs", "port": 8008 }, { "scope": "private", "transform": "shs", "port": 8008, "host": "127.0.0.1" } ] }, "outgoing": { "net": [ { "transform": "shs" } ] } } } EOF ```

qo-op commented

2020-03-23 11:18:17 +01:00

Yeah this is coming from "Astroport" install where SSB node is a Pub.
I am trying to clarify that multiple Node configurations into same install script.

Yeah this is coming from "Astroport" install where SSB node is a Pub. I am trying to clarify that multiple Node configurations into same install script.

qo-op commented

2020-03-30 03:18:29 +02:00

Modified install.sh in dev-fred
Could you merge with master @poka @boris?
I don't have rigths

git push origin master
To https://git.p2p.legal/axiom-team/ssb-g1-tip.git
 ! [rejected]        master -> master (non-fast-forward)
error: impossible de pousser des références vers 'https://git.p2p.legal/axiom-team/ssb-g1-tip.git'
astuce: Les mises à jour ont été rejetées car la pointe de la branche courante est derrière
astuce: son homologue distant. Extrayez cette branche et intégrez les changements distants
astuce: (par exemple 'git pull ...') avant de pousser à nouveau.
astuce: Voir la 'Note à propos des avances rapides' dans 'git push --help' pour plus d'information.

Modified install.sh in dev-fred Could you merge with master @poka @boris? I don't have rigths ``` git push origin master To https://git.p2p.legal/axiom-team/ssb-g1-tip.git ! [rejected] master -> master (non-fast-forward) error: impossible de pousser des références vers 'https://git.p2p.legal/axiom-team/ssb-g1-tip.git' astuce: Les mises à jour ont été rejetées car la pointe de la branche courante est derrière astuce: son homologue distant. Extrayez cette branche et intégrez les changements distants astuce: (par exemple 'git pull ...') avant de pousser à nouveau. astuce: Voir la 'Note à propos des avances rapides' dans 'git push --help' pour plus d'information. ```

poka commented

2020-03-30 03:30:30 +02:00

Done

qo-op commented

2020-03-30 15:38:45 +02:00

Could you audit code?
Now install script ask if you want to install ssb-server
and backup old one if you answer 'y'

Could you audit code? Now install script ask if you want to install ssb-server and backup old one if you answer 'y'

qo-op closed this issue

2020-03-30 15:38:45 +02:00

Sign in to join this conversation.

No Label

No Milestone

No Assignees

3 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: axiom-team/ssb-g1-tip#4